Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade HtmlUnit from 2.x to 3.x #296

Closed
wants to merge 5 commits into from

Conversation

timja-bot
Copy link

This is an autogenerated PR for updating HtmlUnit

It follows the migration guide

Migration steps for cases the script can't handle

This migration currently can't handle HtmlOption changes properly.
If it fails to compile on HtmlOption then revert the specific case:

--- a/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
+++ b/src/test/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptorTest.java
@@ -114,7 +114,7 @@ public class ExtendedEmailPublisherDescriptorTest {
      assertEquals(
              "Plain text should be selected by default",
              "text/plain",
-                contentType.getSelectedOptions().get(0).getValue());
+                contentType.getSelectedOptions().get(0).getValueAttribute());

Ping @timja if any questions

script source

@timja-bot timja-bot added the dependencies Pull requests that update a dependency file label Jun 5, 2023
@basil basil requested a review from a team June 16, 2023 16:49
Jenkinsfile Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest closing in favor of #297.

@@ -30,7 +30,7 @@

<properties>
<changelist>999999-SNAPSHOT</changelist>
<jenkins.version>2.332.1</jenkins.version>
<jenkins.version>2.387.3</jenkins.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this baseline bump necessary?

Comment on lines +5 to +9
buildPlugin(
useContainerAgent: false, // Set to `false` if you need to use Docker for containerized tests
configurations: [
[platform: 'linux', jdk: 17],
[platform: 'windows', jdk: 11],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buildPlugin(
useContainerAgent: false, // Set to `false` if you need to use Docker for containerized tests
configurations: [
[platform: 'linux', jdk: 17],
[platform: 'windows', jdk: 11],
buildPlugin(useContainerAgent: false, configurations: [
[platform: 'linux', jdk: 17],
[platform: 'maven-11-windows', jdk: 11] // TODO Docker-based tests fail when using Docker on Windows. The maven-windows agents do not have Docker installed so tests that require Docker are skipped.

@timja timja closed this Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants