-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade HtmlUnit from 2.x to 3.x #296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest closing in favor of #297.
@@ -30,7 +30,7 @@ | |||
|
|||
<properties> | |||
<changelist>999999-SNAPSHOT</changelist> | |||
<jenkins.version>2.332.1</jenkins.version> | |||
<jenkins.version>2.387.3</jenkins.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this baseline bump necessary?
buildPlugin( | ||
useContainerAgent: false, // Set to `false` if you need to use Docker for containerized tests | ||
configurations: [ | ||
[platform: 'linux', jdk: 17], | ||
[platform: 'windows', jdk: 11], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
buildPlugin( | |
useContainerAgent: false, // Set to `false` if you need to use Docker for containerized tests | |
configurations: [ | |
[platform: 'linux', jdk: 17], | |
[platform: 'windows', jdk: 11], | |
buildPlugin(useContainerAgent: false, configurations: [ | |
[platform: 'linux', jdk: 17], | |
[platform: 'maven-11-windows', jdk: 11] // TODO Docker-based tests fail when using Docker on Windows. The maven-windows agents do not have Docker installed so tests that require Docker are skipped. |
This is an autogenerated PR for updating HtmlUnit
It follows the migration guide
Migration steps for cases the script can't handle
This migration currently can't handle
HtmlOption
changes properly.If it fails to compile on
HtmlOption
then revert the specific case:Ping
@timja
if any questionsscript source