Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JSR 305 #249

Merged
merged 2 commits into from
May 10, 2022
Merged

Remove JSR 305 #249

merged 2 commits into from
May 10, 2022

Conversation

offa
Copy link
Contributor

@offa offa commented Feb 4, 2022

Removes JSR 305 and adds missing annotations.

There were two asserts, which are replaced by an actual check too.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@offa
Copy link
Contributor Author

offa commented Feb 28, 2022

ping @rsandell

@rsandell rsandell added the chore label May 10, 2022
@rsandell rsandell merged commit 17123be into jenkinsci:master May 10, 2022
@offa offa deleted the jsr305 branch May 10, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsandell rsandell rsandell approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@offa @rsandell