Feature/thread start container jnlp

[mat1e]

See #757 and JENKINS-59790.

With JNLP connection method, adding a Jenkins node is asynchronous with when the container starts.

It is a problem when Jenkins is slow and the docker container start very quickly. The node is not yet created on Jenkins when the container ask to connect.

This solution delays the container start until the Jenkins node is created for JNLP.

[pjdarton]

While I appreciate that there's a race condition that sometimes interferes with a smooth startup of JNLP nodes, these code changes appear to break SSH-nodes.
See the automated test results: https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fdocker-plugin/detail/PR-770/1/tests

Any improvement to JNLP nodes must not come as a cost of breaking SSH nodes; these code changes cannot be accepted if they break SSH.

[mat1e]

While I appreciate that there's a race condition that sometimes interferes with a smooth startup of JNLP nodes, these code changes appear to break SSH-nodes.
See the automated test results: https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fdocker-plugin/detail/PR-770/1/tests

Any improvement to JNLP nodes must not come as a cost of breaking SSH nodes; these code changes cannot be accepted if they break SSH.

Thanks, I was looking for theses results.

[pjdarton]

FYI you can find the automated build results from the github page.
There's a "show all checks" link which, when clicked, lists the kinds of tests done and, on the right hand side of each, a "Details" link that, for Jenkins code, will take you to the ci.jenkins.io (Jenkins) server that runs the builds.
In there, you'll find links to the build console output, the unit test results, plus any build artifacts that it built (useful if you want to share your PR's code with others on the internet!).

[mat1e]

While I appreciate that there's a race condition that sometimes interferes with a smooth startup of JNLP nodes, these code changes appear to break SSH-nodes.
See the automated test results: https://ci.jenkins.io/blue/organizations/jenkins/Plugins%2Fdocker-plugin/detail/PR-770/1/tests

Any improvement to JNLP nodes must not come as a cost of breaking SSH nodes; these code changes cannot be accepted if they break SSH.

It is fixed.

[pjdarton]

Closing. #789 superceded this PR.