Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devices flag support #685

Closed
wants to merge 1 commit into from
Closed

Conversation

kaisoz
Copy link
Contributor

@kaisoz kaisoz commented Sep 13, 2018

Hello everybody

I needed to use the devices flag in order to map devices to my container, so I implemented it. For the implementation, I followed the coding style used for other flags (volumes, etc). I'm currently using it in Jenkins 2.14.

@kaisoz
Copy link
Contributor Author

kaisoz commented Sep 14, 2018

why the CI failed? I only see a "Sending interrupt signal to process" :?

@pjdarton
Copy link
Member

I agree, it doesn't appear to be a failure in your code. The jenkinsci process isn't perfect.
FYI if any of the parallel builds fail, all the others will get cancelled, so you'll see those being interrupted - the true error is in the build that wasn't interrupted but which failed for some other reasons, thus triggering the cancellation of the others.

Try closing the PR, waiting 15 minutes, then re-opening it. I've found that in situations where jenkinsci fails to build, it can re-trigger.
If that doesn't work, push a dummy commit.

@kaisoz kaisoz closed this Sep 17, 2018
@kaisoz kaisoz mentioned this pull request Sep 17, 2018
@pjdarton
Copy link
Member

FYI you should be able to "re-open" the same PR rather than opening a new one, but what you did worked, it then built ok, and I've merged it - it'll be part of the next release.

Thank you for your contribution.

@kaisoz
Copy link
Contributor Author

kaisoz commented Sep 21, 2018

I'll take it into account from now on. Thank you very much for accepting the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants