Fix test #417
Merged
Fix test #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s see if this fixes the test for good. I kind of gave up on looking for a solution because I was unable to reproduce it on my machine in the first place. Hence the ugly loop 😅 Thanks for the help! |
|
Thanks! Can this be released for BOM? |
|
I am currently out of town but will be back by the end of the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was timing out frequently when running it locally as well as in BOM (preventing a new BOM release). By switching to
configure.refresh()to a freshwebClient.getPage(project, "configure")I was able to chase away the problem and eliminate the need for a CPU-bound while loop, which seemed bad in general. I have been running this modified version of the test in a loop locally over 12 iterations so far without error, while before this PR it would have failed within 3-4 iterations.