-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
custom-folder-icon 2.11 fails tests in plugin bill of materials #280
Comments
The tests did not yet exist in 2.10. Removing them should not be an option. I can not reproduce any failing tests locally or on jenkins.io.
This seems like something related to the job-dsl-plugin - any idea why these tests do not fail locally? Log output
|
|
So it seems like in order to successfully run
In my plugin Could it be that resolving Possibly related to jenkinsci/maven-hpi-plugin#391 |
I don't have a good explanation why it is needed, but I believe it is valid to include config-file-provider as a test dependency of custom-folder-icon if that allows the new Job DSL test to also be run in the plugin bill of materials. I think that you are right that the behavior is related to jenkinsci/maven-hpi-plugin#391 although I don't understand the details. The Job DSL plugin dependencies include an optional dependency on config-file-provider plugin. That optional dependency seems to not be resolved in the context of the additional plugins that are loaded into the test environment by the plugin bill of materials. In other failure cases like this, we've been able to find a subset of the plugin bom dependencies that would cause the plugin test to fail in the plugin's own repository. However, since you've already found that the addition of a test scoped dependency on config-file-provider resolves the failure, I'm not sure that it is worth the effort to find that subset of dependencies that will show the failure in the plugin's own repository. It seems reasonable to add that test dependency with a comment that it is needed for the plugin bill of materials and can be removed in the future once plugin bill of materials testing no longer requires it. |
Co-authored-by: Mark Waite <[email protected]>
Jenkins and plugins versions report
Jenkins 2.426.1 has a test failure in the plugin bill of materials with custom folder icon 2.11. Test failure is noted in:
What Operating System are you using (both controller, and any agents involved in the problem)?
Linux
Reproduction steps
Expected Results
Tests should pass with custom folder icon plugin 2.11 as they did with custom folder icon plugin 2.10
Actual Results
Tests fail with 2.11 but pass with 2.10
Anything else?
No response
Are you interested in contributing a fix?
No response
The text was updated successfully, but these errors were encountered: