Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use themable symbol instead of svg source #2597

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Use themable symbol instead of svg source #2597

merged 2 commits into from
Nov 19, 2024

Conversation

jonesbusy
Copy link
Contributor

@jonesbusy jonesbusy commented Nov 19, 2024 •
edited
Loading

Use themable symbol instead of svg source

Before

before_jcasc1

After

Default

after_jcasc1

Dark

after_jcasc2

Your checklist for this pull request

🚨 Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or in Jenkins JIRA
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Did you provide a test-case? That demonstrates feature works or fixes the issue.

@jonesbusy jonesbusy requested a review from a team as a code owner November 19, 2024 12:45
timja
timja reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks for the PR, here's my thoughts atm:

README.md Outdated Show resolved Hide resolved
plugin/pom.xml Show resolved Hide resolved
plugin/src/main/resources/images/symbols/logo.svg Outdated Show resolved Hide resolved
@jonesbusy
Copy link
Contributor Author

I have restored the original logo for the readme only

@timja timja merged commit 79281e0 into jenkinsci:master Nov 19, 2024
17 checks passed
@jonesbusy jonesbusy deleted the feature/themable-symbol branch November 19, 2024 17:14
@jonesbusy
Copy link
Contributor Author

https://github.com/jenkinsci/configuration-as-code-plugin/actions/runs/11919116816/job/33218127817#step:4:1

@timja Again a maven download falure here

@timja
Copy link
Member

timja commented Nov 19, 2024

filed jenkins-infra/github-reusable-workflows#40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janfaracik janfaracik janfaracik left review comments

@timja timja timja left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonesbusy @timja @janfaracik