Support custom init script in built-in images #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
commented
Dec 19, 2024
| @QueryParameter String agentLaunchMethod) { | ||
| @QueryParameter String agentLaunchMethod, | ||
| @QueryParameter String imageTopLevelType) { | ||
| if (Constants.IMAGE_TOP_LEVEL_BASIC.equals(imageTopLevelType)) { |
There was a problem hiding this comment.
Requires jenkinsci/jenkins#10081 to work as otherwise its always advanced as thats the last element (/ closest element to the init script)
Doesn't cause any harm though, just means a warning message is showing that doesn't need to be there
timja
force-pushed
the
custom-init-script-basic
branch
from
07e855c to
247b0d1
Compare
timja
commented
Dec 19, 2024
| if (StringUtils.isBlank(value)) { | ||
| return FormValidation.warningWithMarkup(Messages.Azure_GC_InitScript_Warn_Msg()); | ||
| return FormValidation.okWithMarkup(Messages.Azure_GC_InitScript_Warn_Msg()); |
There was a problem hiding this comment.
used ok so-as not to worry people using built-in or that just don't need an init script
timja
force-pushed
the
custom-init-script-basic
branch
from
247b0d1 to
5d9f68d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #293
Testing done
Tested adding
jqin both basic and advanced images for linuxTested termination script in linux basic template
Tested installing
jqin windows 2022 basic imageNot tested inbound agents
Submitter checklist