Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SSH launcher not being exported by JCasC #589

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

timja
Copy link
Member

@timja timja commented Nov 24, 2024

  • Handle SSH launcher not being exported by JCasC
  • Handle null init script (as jelly submits empty string and JCasC does null)
  • Create a node properties list copy so we don't accidentally add the FQDN variable to the template

Fixes #567

I wasn't able to figure out why it wasn't being exported, would need to refresh myself on this area of jcasc code and it would take a lot more effort than this simple patch

Testing done

Tested without providing a launcher in jcasc and it now works

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the bug label Nov 24, 2024
@timja timja enabled auto-merge (squash) November 24, 2024 17:19
@timja timja merged commit 88fcc9f into jenkinsci:master Nov 24, 2024
16 checks passed
@timja timja deleted the handle-missing-launcher-in-jcasc branch November 24, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JCasC configuration for Azure VM Agent missing "launcher: ssh" attribute when default launch type is ssh
1 participant