Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow template updates after JCasC configuration generation #558

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

timja
Copy link
Member

@timja timja commented Sep 18, 2024

Fixes #504

Guessing its some readResolve error after JCasC generates the objects.
Quite odd though, appears this was just a typo and not intentional though.

Testing done

Manually tested removing and re-adding after viewing JCasC configuration.
Reproduced before and can't reproduce after

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the bug label Sep 18, 2024
@timja timja enabled auto-merge (squash) September 18, 2024 11:13
@timja timja merged commit e27457d into master Sep 18, 2024
15 of 16 checks passed
@timja timja deleted the allow-updating-after-jcasc-gen branch September 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant