Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-74036] Extract inline script from ActiveDirectoryStatus/index.jelly #209

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

yaroslavafenkin
Copy link
Contributor

https://issues.jenkins.io/browse/JENKINS-74036

Testing done

Under Manage Jenkins go to the Active Directory Health Status page. The inline script block was defining a display function in the global scope. I've verified that function is also available in global scope after the change. That function is passed as a callback to the progressiveRendering tag:

<l:progressiveRendering handler="${it.startDomainHealthChecks(domain)}" callback="display" tooltip="Checking Domain Controllers..."/>
.

Before the change
After the change

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Copy link
Member

@basil basil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@basil basil merged commit af28000 into jenkinsci:master Nov 4, 2024
17 checks passed
@basil basil added the internal label Nov 4, 2024
@basil
Copy link
Member

basil commented Nov 6, 2024

@jenkinsci/active-directory-plugin-developers Can this please be released? A release is needed so that users can prepare for a future in which CSP is more broadly adopted in Jenkins.

@basil
Copy link
Member

basil commented Nov 8, 2024

@fbelzunc Gentle ping. Can this please be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants