Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate document data only if it has override #73

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Incorporate document data only if it has override #73

merged 1 commit into from
Mar 4, 2020

Conversation

ashmaroli
Copy link
Member

Currently on master, doc.site.config gets duplicated for every doc that gets mentionified.
This can be limited by duplicating the site config for only those doc objects that have the key jekyll-mentions in their front matter.

@ashmaroli ashmaroli requested a review from a team February 27, 2020 05:34
@ashmaroli ashmaroli requested a review from mattr- March 4, 2020 15:49
@mattr-
Copy link
Member

mattr- commented Mar 4, 2020

mentionified

what an amazing word. ✨

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 564fbcd into jekyll:master Mar 4, 2020
jekyllbot added a commit that referenced this pull request Mar 4, 2020
@jekyllbot
Update history to reflect merge of #73 [ci skip]
2bf5c39
@ashmaroli ashmaroli deleted the conditionally-incorporate-doc-data branch March 4, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@mattr- mattr- mattr- approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ashmaroli @mattr- @DirtyF @jekyllbot