Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce style checks #67

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Reintroduce style checks #67

merged 1 commit into from
Dec 6, 2018

Conversation

ashmaroli
Copy link
Member

  • RuboCop failed earlier because the master branch did not inherit config from rubocop-jekyll
  • Additional exclusions for spec files

@ashmaroli ashmaroli requested a review from DirtyF December 6, 2018 11:22
DirtyF
DirtyF approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@DirtyF
Copy link
Member

DirtyF commented Dec 6, 2018

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 1c5cad6 into jekyll:master Dec 6, 2018
jekyllbot added a commit that referenced this pull request Dec 6, 2018
@jekyllbot
Update history to reflect merge of #67 [ci skip]
ca3149e
@ashmaroli ashmaroli deleted the reintroduce-style-checks branch December 6, 2018 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirtyF DirtyF DirtyF approved these changes

Assignees
No one assigned
Labels
fix internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashmaroli @DirtyF @jekyllbot