Use default Rake tasks and scripts #55
Conversation
| @@ -1,5 +1,7 @@ | |||
| #! /bin/sh | |||
|
|
|||
| bundle exec rspec | |||
| bundle exec rubocop -S -D | |||
| gem build jekyll-mentions.gemspec | |||
There was a problem hiding this comment.
Do we not want to test that dependencies resolve and that the Gem builds?
There was a problem hiding this comment.
We do, default bundler rake task bundle exec rake build should take care of that.
| @@ -1,5 +1,5 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| module JekyllMentions | |||
| VERSION = "1.2.0" | |||
| VERSION = "1.2.0".freeze | |||
There was a problem hiding this comment.
This shouldn't be necessary because of frozen_string_literal: true
There was a problem hiding this comment.
yeah but Rubcop complains for older Rubies and we don't want to target Ruby 2.3+ for now 😉
There was a problem hiding this comment.
Then let's ignore this cop. This is nonsensical.
There was a problem hiding this comment.
I guess it's what Jekyll does, so 🤷♂️
There was a problem hiding this comment.
I agree, we should fix that in Jekyll's config.
There was a problem hiding this comment.
By adding an explicit freeze call, the constant is guaranteed frozen on all supported Rubies instead of just 2.3+.
There was a problem hiding this comment.
So let’s drop the magic comment.
There was a problem hiding this comment.
:) why is this bothering you so much..?
There was a problem hiding this comment.
I’m grumpy 😜
You’re right; it doesn’t matter.
There was a problem hiding this comment.
Don't worry @pathawks , I promise we'll get rid of all those useless .freeze at the end of march when we stop supporting EOL rubies :)
|
@jekyllbot: |
+dev
This PR intent is to normalize the documentation for testing and releasing Jekyll plugins.
https://jekyllrb.com/docs/maintaining/releasing-a-new-version/#for-non-core-gems