Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rubocop to script/cibuild #44

Merged
merged 2 commits into from
May 3, 2017
Merged

Add rubocop to script/cibuild #44

merged 2 commits into from
May 3, 2017

Conversation

benbalter
Copy link
Contributor

Went to verify a behavior, rand noticed a few ways we deviated from other Jekyll-maintained plugins. This PR:

  • Adds rubocop and building the gem to CI
  • Moves Rspec options to .rspec
  • Removes the unused Rakefile
  • Adds Rubocop to the Gemspec
  • Runs rubocop -a

@pathawks
Copy link
Member

pathawks commented May 3, 2017 

nokogiri requires Ruby version >= 2.1.0.

@benbalter
Copy link
Contributor Author

@jekyllbot: merge +dev.

@jekyllbot jekyllbot merged commit 02984c2 into master May 3, 2017
@jekyllbot jekyllbot deleted the rubocop branch May 3, 2017 14:18
jekyllbot added a commit that referenced this pull request May 3, 2017
@jekyllbot
Update history to reflect merge of #44 [ci skip]
d7b9e0c
@jekyllbot jekyllbot mentioned this pull request Mar 14, 2018
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pathawks pathawks pathawks approved these changes

Assignees
No one assigned
Labels
fix internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbalter @pathawks @jekyllbot