Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stuff that was deprecated for 2.5.0 #1425

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

n2ygk
Copy link
Member

@n2ygk n2ygk commented May 22, 2024

Description of the Change

Removes deprecations that were warned would be removed in 2.5.0

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk added this to the 2.5.0 milestone May 22, 2024
@n2ygk n2ygk requested review from dopry and tonial May 22, 2024 18:47
@n2ygk
Copy link
Member Author

n2ygk commented May 22, 2024

@dopry @tonial I took a crack at removing the deprecations you had added. Please take a look and make sure I didn't mess it up.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.42%. Comparing base (560f84d) to head (24ed763).
Report is 14 commits behind head on master.

Current head 24ed763 differs from pull request most recent head 692ab13

Please upload reports for the commit 692ab13 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   97.56%   97.42%   -0.14%     
==========================================
  Files          32       32              
  Lines        2132     2096      -36     
==========================================
- Hits         2080     2042      -38     
- Misses         52       54       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dopry dopry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at a glance. I'll give it a more thorough review tomorrow.

Copy link
Contributor

@tonial tonial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me 👍

@dopry
Copy link
Contributor

dopry commented Jun 10, 2024

Sorry work got the better for me for a hearbeat. LGTM.

@n2ygk n2ygk force-pushed the 2_5_0_deprecations branch from a24e1c3 to c46e38e Compare June 12, 2024 13:18
@n2ygk
Copy link
Member Author

n2ygk commented Jun 12, 2024

ugh codespell is messing us up.

@n2ygk n2ygk merged commit 5185d20 into jazzband:master Jun 12, 2024
25 checks passed
@n2ygk n2ygk deleted the 2_5_0_deprecations branch June 12, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants