-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stuff that was deprecated for 2.5.0 #1425
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1425 +/- ##
==========================================
- Coverage 97.56% 97.42% -0.14%
==========================================
Files 32 32
Lines 2132 2096 -36
==========================================
- Hits 2080 2042 -38
- Misses 52 54 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at a glance. I'll give it a more thorough review tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me 👍
Sorry work got the better for me for a hearbeat. LGTM. |
a24e1c3
to
c46e38e
Compare
ugh codespell is messing us up. |
…ures until we can better tune it.
Description of the Change
Removes deprecations that were warned would be removed in 2.5.0
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS