-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1185 add token to request #1304
Conversation
for more information, see https://pre-commit.ci
…go-oauth-toolkit into issue-1185-middleware-token
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
+ Coverage 97.35% 97.37% +0.02%
==========================================
Files 32 32
Lines 2005 2022 +17
==========================================
+ Hits 1952 1969 +17
Misses 53 53
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…go-oauth-toolkit into issue-1185-middleware-token
for more information, see https://pre-commit.ci
Please fill out the checklist in the PR description above and add the issue number after It is important to document any new functionality and to write automated tests. See https://django-oauth-toolkit.readthedocs.io/en/latest/contributing.html |
Thanks for the feedback. I am not sure if this is considered relevant for the changelog - let me know. I've done the other stuff. |
Yes please add to the changelog since you are adding functionality potentially used by some other user of the package. And please rebase since master has had some commits added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jhnbyrn. Thanks for this contribution.
Fixes #1185
Description of the Change
Add the Token object to the request in the middleware. This makes it easy to access the Application object in views.
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS