Expect the remote exp to be defined in time zone UTC conform rfc (Fix… #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkleinheerenbrink
force-pushed
the
master
branch
from
a36e65f to
b2e2828
Compare
|
@wkleinheerenbrink could you rebase this PR to resolve the conflicts? I'll prioritize reviewing it in the next few days. |
|
I have this issue too; can I continue this? |
|
https://docs.python.org/3/library/zoneinfo.html was added in Python 3.9 so the 3.8 tests fail because functools.lru_cache fails to cache the Import exception. |
n2ygk
reviewed
May 7, 2024
n2ygk
reviewed
May 7, 2024
n2ygk
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1291
Description of the Change
Interpret the EXP in access tokens as being UTC. Introduces an extra setting
AUTHENTICATION_SERVER_EXP_TIME_ZONEto allow for the workaround in case of a remote authentication server that, wrongly, does not server the EXP in UTC.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS