Test Django 4.1 and remove upper version bound #1203
Conversation
|
@n2ygk @Andrew-Chen-Wang , since you worked on #1175 which added this version bound. |
Codecov Report
@@ Coverage Diff @@
## master #1203 +/- ##
=======================================
Coverage 96.85% 96.85%
=======================================
Files 31 31
Lines 1813 1813
=======================================
Hits 1756 1756
Misses 57 57 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
adamchainz
force-pushed
the
remove_upper_version_bound
branch
from
43c7729 to
e5f08d9
Compare
| @@ -32,7 +32,7 @@ zip_safe = False | |||
| # jwcrypto has a direct dependency on six, but does not list it yet in a release | |||
| # Previously, cryptography also depended on six, so this was unnoticed | |||
| install_requires = | |||
| django >= 2.2, <= 4.1 | |||
| django >= 2.2, != 4.0.0 | |||
There was a problem hiding this comment.
restoring the block on 4.0.0 which had a bug, as noted here:
There was a problem hiding this comment.
@n2ygk I don't think an upper bound is necessary either. also LGTM
adamchainz
changed the title
n2ygk
force-pushed
the
remove_upper_version_bound
branch
from
854d452 to
6bc1646
Compare
|
@Andrew-Chen-Wang > @n2ygk I don't think an upper bound is necessary either. also LGTM I kinda disagree given the tox tests are failing with djmain. But 2 against 1 wins I guess. |
|
Any idea when we can expect the next release to pypi, including this fix? |
Fixes #1202
Description of the Change
Remove upper version bound, as I recommended on the ticket.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS