Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LOGIN_URL settings in getting_started.rst #1162

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

mumin91
Copy link
Contributor

@mumin91 mumin91 commented May 18, 2022

Fixes #

Description of the Change

Added LOGIN_URL = '/admin/login/' to the settings.py in DOT tutorial for Django REST Framework. Without this, hitting http://localhost:8000/o/applications/ redirects to URL not found error page.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

n2ygk
n2ygk previously requested changes May 18, 2022
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Would you mind helping out a little more and compare getting_started to the tutorial to see if there are any other things missing from getting_started?

Also please add your name to AUTHORS.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1162 (60ee8d5) into master (5d5246a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1162   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files          32       32           
  Lines        2120     2120           
=======================================
  Hits         2068     2068           
  Misses         52       52           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@n2ygk
Copy link
Member

n2ygk commented May 27, 2022

@mumin91 Will you be able to make the requested changes?

@mumin91
Copy link
Contributor Author

mumin91 commented May 27, 2022

@mumin91 Will you be able to make the requested changes?

Yes, I will. But I need sometime for that.

@fdemmer fdemmer added the docs label Aug 5, 2022
@dopry
Copy link
Contributor

dopry commented May 21, 2023

@mumin91 Do you have any time to wrap up this PR?

@dopry dopry self-requested a review November 10, 2023 18:22
Copy link
Contributor

@dopry dopry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is at least an improvement until we can update the getting started docs more completely.

@dopry dopry dismissed n2ygk’s stale review November 10, 2023 18:23

wanted to keep scope to work that is complete to clean up PR backlog.

@dopry dopry merged commit 4f59b06 into jazzband:master Nov 10, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants