-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LOGIN_URL settings in getting_started.rst #1162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Would you mind helping out a little more and compare getting_started to the tutorial to see if there are any other things missing from getting_started?
Also please add your name to AUTHORS.
Codecov Report
@@ Coverage Diff @@
## master #1162 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 32 32
Lines 2120 2120
=======================================
Hits 2068 2068
Misses 52 52 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@mumin91 Will you be able to make the requested changes? |
Yes, I will. But I need sometime for that. |
@mumin91 Do you have any time to wrap up this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is at least an improvement until we can update the getting started docs more completely.
wanted to keep scope to work that is complete to clean up PR backlog.
Fixes #
Description of the Change
Added
LOGIN_URL = '/admin/login/'
to thesettings.py
in DOT tutorial for Django REST Framework. Without this, hittinghttp://localhost:8000/o/applications/
redirects to URL not found error page.Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS