-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken import in doc #1121
Fix broken import in doc #1121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarlSchwan Please do add yourself to AUTHORS anyway. It's not about copyright but about credit for contributing.
Codecov Report
@@ Coverage Diff @@
## master #1121 +/- ##
=======================================
Coverage 96.62% 96.62%
=======================================
Files 32 32
Lines 1806 1806
=======================================
Hits 1745 1745
Misses 61 61 Continue to review full report at Codecov.
|
Never mind. I did it. |
Thanks! |
Description of the Change
inport os.environ
is incorrect since environ is not a module, instead we just need to doimport os
and useos.environ
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS
(not sure if this is needed, that change is not copyrightable because it's too trivial)