-
-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC: Standard scopes to determine which claims are returned #1108
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
=======================================
Coverage 96.61% 96.62%
=======================================
Files 32 32
Lines 1804 1806 +2
=======================================
+ Hits 1743 1745 +2
Misses 61 61
Continue to review full report at Codecov.
|
Is the claims parameter actually supported as stated in the docs? Not really. The claims parameter is supported in The openid-configuration does not assert `"claims_parameter_supported". Per the spec this means it does: "...if omitted, the default value is false." I will remove the docs reference. Scope-based claims release is probably more than enough functionality improvement at this point. This implementation is probably better pushed upstream: oauthlib/oauthlib#799 (comment) |
5619752
to
3976115
Compare
Are you still looking to merge upstream and close this? |
Maybe merge here and then look at what upstream stuff can be done and remove this and other stuff that should be upstream later? There's other stuff like oidc metadata that can also potentially go upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure. lgtm as far as I can tell
Fixes #1107
Description of the Change
Only return standard OIDC claims that are permitted by the granted OIDC scopes (profile, email, address, etc.)
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS