Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1083 ('token' not valid search field), add search fields to all remaining admin classes #1085

Merged
merged 2 commits into from
Jan 11, 2022

Conversation

PetrDlouhy
Copy link
Contributor

@PetrDlouhy PetrDlouhy commented Jan 11, 2022

Fixes #1083

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.65%. Comparing base (68da292) to head (2a85e0a).
Report is 205 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1085   +/-   ##
=======================================
  Coverage   96.64%   96.65%           
=======================================
  Files          31       31           
  Lines        1761     1763    +2     
=======================================
+ Hits         1702     1704    +2     
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n2ygk n2ygk added this to the 1.6.3 milestone Jan 11, 2022
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PetrDlouhy Thanks for the update. I suggest for the future that you install pre-commit locally as described here to avoid these fixes being committed by pre-commit-ci.

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix and extending search to the other models.

In hindsight, it would probably have been a good idea to add tests for the new search functionality in the original PR. The bug is easily reproduced with http://127.0.0.1:8000/admin/oauth2_provider/idtoken/?q=foo

If you've got time, please do submit a new PR with tests for completeness. If not, I understand:-)

@n2ygk n2ygk merged commit baba2ed into jazzband:master Jan 11, 2022
@n2ygk
Copy link
Member

n2ygk commented Jan 11, 2022

I'll cherry-pick this into the stable/1.6 branch shortly.

n2ygk pushed a commit that referenced this pull request Jan 11, 2022
…remaining admin classes (#1085)

* fix #1083 ('token' not valid search field), add search fields to all remaining admin classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'token' not a valid search field in admin
2 participants