Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[context] Expose HandlerType in Context (#1264) #1265

Conversation

spinscale
Copy link
Contributor

Backport of #1264

@tipsy tipsy merged commit bb4b3ba into javalin:javalin-3x Jun 1, 2021
@rbygrave
Copy link
Contributor

rbygrave commented Jun 1, 2021

Noting that context.method() returns the underlying request method (and this is what I suspect people have been using instead). Yes that returns a String and not an enum.

@tipsy
Copy link
Member

tipsy commented Jun 1, 2021

From the original ticket (#1263 (comment)) it seems @spinscale is interested in BEFORE/AFTER too, which is why .method() won't be enough.

@rbygrave
Copy link
Contributor

rbygrave commented Jun 1, 2021

Ah interesting, thanks.

@tipsy
Copy link
Member

tipsy commented Jun 22, 2021

@spinscale this is out now !

@spinscale
Copy link
Contributor Author

thx a ton @tipsy - I can finally resume on supporting javalin in the elastic apm agent - and no I haven't forgotten the headers work, jusy busy with other things :-)

also, hi Rob and thx for ebean (couldn't map your name quite when reading it until now :-)

@tipsy
Copy link
Member

tipsy commented Jun 23, 2021

thx a ton @tipsy - I can finally resume on supporting javalin in the elastic apm agent - and no I haven't forgotten the headers work, jusy busy with other things :-)

No problem, my work on Javalin has also been slow (but steady) lately. I don't want to rush out v4, so take your time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants