Fix float -> u128 conversion bug #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also rust-lang/rust#41799 |
Converting floats to u128 failed because in the comparison "src > u128::MAX as f32" we invoked UB due to the u128::MAX as f32 conversion.
|
r? @japaric and of course, I'll need a new version |
japaric
reviewed
May 7, 2017
| @@ -302,6 +302,37 @@ macro_rules! from_float { | |||
| } | |||
| } | |||
|
|
|||
| /// From a float `$src` to an integer `$dst`, where $dst is large enough to contain | |||
| /// all values of `$src`. We can't ever overflow here | |||
There was a problem hiding this comment.
We can't ever overflow here
Overflow can happen when going from f32 to i128
f32::MAX = 340282350000000000000000000000000000000
i128::MAX = 170141183460469231731687303715884105727
japaric
reviewed
May 7, 2017
| } else if src == $src::INFINITY || | ||
| src == $src::NEG_INFINITY { | ||
| Error::Infinite | ||
| } else if ($dst::MIN == 0) && src < 0.0 { |
There was a problem hiding this comment.
Underflow can happen when going from f32 to i128
f32::MIN = -340282350000000000000000000000000000000
i128::MIN = -170141183460469231731687303715884105728
|
re-r? @japaric |
|
@homunkulus r+ |
|
📌 Commit 868978e has been approved by |
|
💔 Test failed - status-travis |
|
@homunkulus r+ |
|
📌 Commit d492df1 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting floats to u128 failed because in the comparison
"src > u128::MAX as f32" we invoked UB due to the
u128::MAX as f32 conversion.