Added errorMessage and catchError props
#260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user can handle error thrown from `react-native-video` while also keeping error handling mechanism provided by `react-native-video-controls` lib
also fixed `showTimeRemaining` and `showHours` prop doc styling
only minor version upgrade needed as their is no breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No Breaking Changes
Minor Change
Added
errorMessageprop to customize error message shown in Video Player UIAdded
catchErrorprop to handlereact-native-videolib error while also using error handling mechanism provided byreact-native-video-controlslib.The reason for not using the pre-existing
onErrorprop is because it prevents the user from accessing the Error Message UI offered by thereact-native-video-controlslibrary.