-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config: allow to set maps on null value #1570
Conversation
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
There were the following issues with your Pull Request
Guidelines are available to help. Your feedback on GitCop is welcome on this issue This message was auto-generated by https://gitcop.com |
This adds a failing for the case described in ipfs#1561 License: MIT Signed-off-by: Stephan Seidt <[email protected]>
Also, now, if ipfs config foo.bar has value of anything that is not map (0, "0", 0.1), then ipfs config foo.bar.baz now returns an error instead of a panic License: MIT Signed-off-by: rht <[email protected]>
Does this mean we can set config values that dont actually exist in the config struct? like |
This was already possible before. The PR makes it that if one of the key is null, it can be overwritten with a map (bar with value null -> bar.baz). |
@rht okay, seems fine to me then |
Config: allow to set maps on null value
I just realized that afbdedb was before c0a0cde, which means one commit fails tests -- let's order things such that no commit fails tests. otherwise hard to rebase. (this (and github's lack of "issuing a test per commit" is why https://github.com/jbenet/git-push-each exists)) |
Sorry, I did remember switching the order with rebase but didn't check. |
Also, now, if ipfs config foo.bar has value of anything that is not map (0, "0", 0.1),
then ipfs config foo.bar.baz now returns an error instead of a panic
Fixes #1561