Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: allow to set maps on null value #1570

Merged
merged 2 commits into from
Aug 14, 2015
Merged

Config: allow to set maps on null value #1570

merged 2 commits into from
Aug 14, 2015

Conversation

rht
Copy link
Contributor

@rht rht commented Aug 13, 2015

Also, now, if ipfs config foo.bar has value of anything that is not map (0, "0", 0.1),
then ipfs config foo.bar.baz now returns an error instead of a panic

Fixes #1561

@GitCop
Copy link

GitCop commented Aug 13, 2015

There were the following issues with your Pull Request

  • Commit: c6d1413
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Aug 13, 2015

There were the following issues with your Pull Request

  • Commit: 183a524
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines are available to help. Your feedback on GitCop is welcome on this issue


This message was auto-generated by https://gitcop.com

seidtgeist and others added 2 commits August 13, 2015 19:41
This adds a failing for the case described in ipfs#1561

License: MIT
Signed-off-by: Stephan Seidt <[email protected]>
Also, now, if ipfs config foo.bar has value of anything that is not map (0, "0", 0.1),
then ipfs config foo.bar.baz now returns an error instead of a panic

License: MIT
Signed-off-by: rht <[email protected]>
@whyrusleeping
Copy link
Member

Does this mean we can set config values that dont actually exist in the config struct? like foo.bar.baz?

@rht
Copy link
Contributor Author

rht commented Aug 13, 2015

This was already possible before. The PR makes it that if one of the key is null, it can be overwritten with a map (bar with value null -> bar.baz).

@whyrusleeping
Copy link
Member

@rht okay, seems fine to me then

jbenet added a commit that referenced this pull request Aug 14, 2015
Config: allow to set maps on null value
@jbenet jbenet merged commit da75e92 into ipfs:master Aug 14, 2015
@jbenet jbenet removed the status/in-progress In progress label Aug 14, 2015
@jbenet
Copy link
Member

jbenet commented Aug 15, 2015

I just realized that afbdedb was before c0a0cde, which means one commit fails tests -- let's order things such that no commit fails tests. otherwise hard to rebase.

(this (and github's lack of "issuing a test per commit" is why https://github.com/jbenet/git-push-each exists))

@rht
Copy link
Contributor Author

rht commented Aug 15, 2015

Sorry, I did remember switching the order with rebase but didn't check.

@ajnavarro ajnavarro mentioned this pull request Aug 24, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants