config/init: init Version with CheckPeriod #265

ipfs · Nov 5, 2014 · c6b7420 · c6b7420
1 parent 866c2c8
commit c6b7420
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/cmd/ipfs/init.go b/cmd/ipfs/init.go
@@ -136,10 +136,7 @@ func initCmd(c *commander.Command, inp []string) error {
 	}
 
 	// tracking ipfs version used to generate the init folder and adding update checker default setting.
-	cfg.Version = config.Version{
-		Check:   "error",
-		Current: updates.Version,
-	}
+	cfg.Version = config.VersionDefaultValue()
 
 	err = config.WriteConfigFile(filename, cfg)
 	if err != nil {

diff --git a/config/version.go b/config/version.go
@@ -127,8 +127,18 @@ func RecordUpdateCheck(cfg *Config, filename string) {
 
 	if cfg.Version.CheckPeriod == "" {
 		// CheckPeriod was not initialized for some reason (e.g. config file broken)
-		cfg.Version.CheckPeriod = strconv.Itoa(int(defaultCheckPeriod))
+		log.Error("config.Version.CheckPeriod not set. config broken?")
 	}
 
 	WriteConfigFile(filename, cfg)
 }
+
+// VersionDefaultValue returns the default version config value (for init).
+func VersionDefaultValue() Version {
+	return Version{
+		Current:     CurrentVersionNumber,
+		Check:       "error",
+		CheckPeriod: strconv.Itoa(int(defaultCheckPeriod)),
+		AutoUpdate:  AutoUpdateMinor,
+	}
+}