Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for parsing USDT arguments to RISC-V #4751

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

andreyviktorov2
Copy link
Contributor

It is currently not possible to use USDT on risc-v due to lack of support for argument parsing. When trying to connect to USDT the following error occurs: link. This patch provides this implementation.

@chenhengqi
Copy link
Collaborator

@xmzzz Would you mind reviewing and testing this change ? Thanks.

@andreyviktorov2
Copy link
Contributor Author

@xmzzz , Hi!
Is there any news about the PR check?

@xmzzz
Copy link
Contributor

xmzzz commented Oct 16, 2023 via email

@andreyviktorov2
Copy link
Contributor Author

On 10/16/23 15:55, @andreyandvitya wrote: @xmzzz https://github.com/xmzzz , Hi! Is there any news about the PR check?
Sorry, I'll give some feedback in the next week or so. Thanks!

— Reply to this email directly, view it on GitHub <#4751 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACVZJN5VHR6R6QPQMROJ3GDX7TR63ANCNFSM6AAAAAA5LCPQKY. You are receiving this because you were mentioned.Message ID: @.***>

Hi @xmzzz ! Is there any news?

@xmzzz
Copy link
Contributor

xmzzz commented Nov 1, 2023

Hi @andreyviktorov2 .

I reproduced the error about Parse error: in the QEMU RISC-V and tested this patch. It works fine.
But I noticed that this PR contains two wrong commits, maybe you should rebase to master instead of merge.

Here are my test results and test environment:

ubuntu@ubuntu:~/todo/bcc-test$ sudo tplist.py -vv -l ./simple-c
test-app:test-probe [sema 0x0]
  location #1 ./simple-c 0x76a
    argument #1 8 signed   bytes @ a5

ubuntu@ubuntu:~/todo/bcc-test$ sudo trace.py 'u:/home/ubuntu/todo/bcc-test/simple-c:test-probe "%u", arg1' -T -p $(pidof simple-c)
TIME     PID     TID     COMM            FUNC             -
16:55:20 4223    4223    simple-c        test-probe       1698857720
16:55:21 4223    4223    simple-c        test-probe       1698857721
16:55:22 4223    4223    simple-c        test-probe       1698857722
16:55:23 4223    4223    simple-c        test-probe       1698857723
16:55:24 4223    4223    simple-c        test-probe       1698857724
^C
ubuntu@ubuntu:~/todo/bcc-test$ uname -a
Linux ubuntu 6.2.0-36-generic #37.1-Ubuntu SMP Tue Oct 10 06:20:55 UTC 2023 riscv64 riscv64 riscv64 GNU/Linux
ubuntu@ubuntu:~/todo/bcc-test$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 23.04
Release:        23.04
Codename:       lunar

@andreyviktorov2
Copy link
Contributor Author

Thanks for the feedback, @xmzzz ! Yes, you are right, I forgot to rebase to master. Fixed it.
But I'm seeing some tests failing that weren't there before. Also saw that the latest PR checks also failed with the same problems.

@andreyviktorov2
Copy link
Contributor Author

@xmzzz Hi!
Please tell me on whose side is the error causing the tests to fail. Do I need to redo something from my side?
Thanks!

@andreyviktorov2
Copy link
Contributor Author

Hi, @xmzzz @chenhengqi
I reran the checks. All were successful. Are there any other restrictions for merging?

@chenhengqi chenhengqi merged commit 003b003 into iovisor:master Nov 17, 2023
12 checks passed
@chenhengqi
Copy link
Collaborator

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants