Revert Config Changes To github_branch_protection
#570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`repository` was previously removed in favour of `repository_id`. We revert to `repository` here and transition `repository_id` to a computed value that is derived from a GraphQL lookup against the provided `repository`. `branch` was previously removed in favour of `pattern`. Similarly, `pattern` becomes computed and takes the value of `branch`. `branch` now becomes deprecated for removal in the next major release.
ghost
added
size/M
Type: Documentation
woodb
reviewed
Oct 19, 2020
There was a problem hiding this comment.
Looks good! There were some other breaking changes that we may want to revert, specifically around changes to required_pull_request_reviews
dismissal_users->dismissal_restrictionsdismissal_teams->dismissal_restrictions
Additionally, dismissal_restrictions is erroneously cited in the docs as dismissal_actors (see #569).
Should we make dismissal_restrictions a computed field w/ actor ID's from dismissal_users and dismissal_teams, adding a deprecation warning for those fields as well?
Comment on lines
+26
to
+28
| Type: schema.TypeString, | ||
| Computed: true, | ||
| Description: "GraphQL `node_id` of a repository", |
| ForceNew: true, | ||
| Description: "", | ||
| Description: "`pattern` for a `BranchProtectionRule`", | ||
| Deprecated: "use `pattern` after v4.0.0 instead", |
Comment on lines
+30
to
+32
| resource.TestCheckResourceAttr( | ||
| "github_branch_protection.test", "branch", "main", | ||
| ), |
|
It would be great if the PR author could add in some state migrations so users that currently define |
Co-authored-by: Brandon Wood <[email protected]>
|
Closing this as we've discussed rolling forward with v4.0.0 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repositorywas previously removed in favour ofrepository_id. Werevert to
repositoryhere and transitionrepository_idto a computedvalue that is derived from a GraphQL lookup against the provided
repository.branchwas previously removed in favour ofpattern. Similarly,patternbecomes computed and takes the value ofbranch.branchnow becomes deprecated for removal in the next major release.
Fixes https://github.com/terraform-providers/terraform-provider-github/issues/566