Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for issues using github_issue resource #1047

Merged
merged 2 commits into from
Mar 18, 2022

Conversation

ewilde
Copy link
Contributor

@ewilde ewilde commented Jan 23, 2022

Summary

Introduce support for managing github issues using the terraform provider.

Closes: #958

Signed-off-by: Edward Wilde [email protected]

Tasks:

  • github_issue.go (create, update, delete)
    • Title attribute
    • Body
    • Labels
    • Milestone
    • Projects
    • Assignees
  • github_issue_test test with an individual account
  • github_issue_test test with an organisational account
  • State import test
  • Documentation update for github_issue resource

Testing

TestAccGithubIssue

go tool test2json -t /tmp/GoLand/___TestAccGithubIssue_in_github_com_terraform_providers_terraform_provider_github_github.test -test.v -test.paniconexit0 -test.run ^\QTestAccGithubIssue\E$
=== RUN   TestAccGithubIssue
--- PASS: TestAccGithubIssue (60.57s)
=== RUN   TestAccGithubIssue/creates_an_issue_without_error
    --- PASS: TestAccGithubIssue/creates_an_issue_without_error (39.70s)
=== RUN   TestAccGithubIssue/creates_an_issue_without_error/with_an_anonymous_account
    resource_github_issue_test.go:115: anonymous account not supported for this operation
        --- SKIP: TestAccGithubIssue/creates_an_issue_without_error/with_an_anonymous_account (0.00s)

Test ignored.
=== RUN   TestAccGithubIssue/creates_an_issue_without_error/with_an_individual_account
        --- PASS: TestAccGithubIssue/creates_an_issue_without_error/with_an_individual_account (19.81s)
=== RUN   TestAccGithubIssue/creates_an_issue_without_error/with_an_organization_account
        --- PASS: TestAccGithubIssue/creates_an_issue_without_error/with_an_organization_account (19.89s)

Test ignored.
=== RUN   TestAccGithubIssue/imports_a_issue_without_error
    --- PASS: TestAccGithubIssue/imports_a_issue_without_error (20.87s)
=== RUN   TestAccGithubIssue/imports_a_issue_without_error/with_an_anonymous_account
    resource_github_issue_test.go:164: anonymous account not supported for this operation
        --- SKIP: TestAccGithubIssue/imports_a_issue_without_error/with_an_anonymous_account (0.00s)

Test ignored.
=== RUN   TestAccGithubIssue/imports_a_issue_without_error/with_an_individual_account
        --- PASS: TestAccGithubIssue/imports_a_issue_without_error/with_an_individual_account (10.40s)
=== RUN   TestAccGithubIssue/imports_a_issue_without_error/with_an_organization_account
        --- PASS: TestAccGithubIssue/imports_a_issue_without_error/with_an_organization_account (10.47s)

Test ignored.

Test ignored.
PASS

TestAccGithubProjectCard

go tool test2json -t /tmp/GoLand/___TestAccGithubProjectCard_in_github_com_terraform_providers_terraform_provider_github_github.test -test.v -test.paniconexit0 -test.run ^\QTestAccGithubProjectCard\E$
=== RUN   TestAccGithubProjectCard
--- PASS: TestAccGithubProjectCard (58.46s)
=== RUN   TestAccGithubProjectCard/creates_a_project_card_using_a_note
    --- PASS: TestAccGithubProjectCard/creates_a_project_card_using_a_note (12.65s)
=== RUN   TestAccGithubProjectCard/creates_a_project_card_using_a_note/with_an_anonymous_account
    resource_github_project_card_test.go:57: anonymous account not supported for this operation
        --- SKIP: TestAccGithubProjectCard/creates_a_project_card_using_a_note/with_an_anonymous_account (0.00s)

Test ignored.
=== RUN   TestAccGithubProjectCard/creates_a_project_card_using_a_note/with_an_individual_account
    resource_github_project_card_test.go:61: individual account not supported for this operation
        --- SKIP: TestAccGithubProjectCard/creates_a_project_card_using_a_note/with_an_individual_account (0.00s)

Test ignored.
=== RUN   TestAccGithubProjectCard/creates_a_project_card_using_a_note/with_an_organization_account
        --- PASS: TestAccGithubProjectCard/creates_a_project_card_using_a_note/with_an_organization_account (12.65s)

Test ignored.
=== RUN   TestAccGithubProjectCard/creates_a_project_card_using_an_issue
    --- PASS: TestAccGithubProjectCard/creates_a_project_card_using_an_issue (45.81s)
=== RUN   TestAccGithubProjectCard/creates_a_project_card_using_an_issue/with_an_anonymous_account
    resource_github_project_card_test.go:134: anonymous account not supported for this operation
        --- SKIP: TestAccGithubProjectCard/creates_a_project_card_using_an_issue/with_an_anonymous_account (0.00s)

Test ignored.
=== RUN   TestAccGithubProjectCard/creates_a_project_card_using_an_issue/with_an_individual_account
        --- PASS: TestAccGithubProjectCard/creates_a_project_card_using_an_issue/with_an_individual_account (23.26s)
=== RUN   TestAccGithubProjectCard/creates_a_project_card_using_an_issue/with_an_organization_account
        --- PASS: TestAccGithubProjectCard/creates_a_project_card_using_an_issue/with_an_organization_account (22.55s)

Test ignored.

Test ignored.
PASS

Process finished with the exit code 0

@ewilde ewilde force-pushed the ewilde-github_issue branch 8 times, most recently from 790497c to 7877ec4 Compare January 24, 2022 17:21
@ewilde ewilde marked this pull request as ready for review January 24, 2022 17:21
@ewilde
Copy link
Contributor Author

ewilde commented Jan 24, 2022

@jcudit this is ready for review now. It's my first contribution to this project. I've found the contributing guide really useful 🙏

Introduce support for managing github issues using the terraform provider.

Closes: integrations#958

Signed-off-by: Edward Wilde <[email protected]>
@ewilde ewilde force-pushed the ewilde-github_issue branch from 7877ec4 to a3a65e2 Compare January 25, 2022 11:27
@kfcampbell kfcampbell added this to the v4.21.0 milestone Jan 31, 2022
@kfcampbell
Copy link
Member

I would be interested to give this a shot in an upcoming version; I've added it to a milestone for a future release.

Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see this get used! Thank you for the contribution.

@farrukh90
Copy link

Hi,
Is this something that can be released on March 9th? This is a huge blocker for us. Also, if this is not released by 9th, can we use the branch another branch as a provider? Does anyone have tutorials on that?

@kfcampbell kfcampbell modified the milestones: v4.21.0, v4.22.0 Mar 11, 2022
@ewilde-form3
Copy link
Contributor

@kfcampbell is there anything remaining that you would like me to do on this PR?

I've been using my fork and managing issue resources. So far not hit any problems

@kfcampbell
Copy link
Member

@ewilde Nope! I'll be merging this shortly and releasing today. Thank you for the contribution!

@kfcampbell kfcampbell merged commit 8a7ea24 into integrations:main Mar 18, 2022
kfcampbell pushed a commit to kfcampbell/terraform-provider-github that referenced this pull request Jul 26, 2022
Introduce support for managing github issues using the terraform provider.

Closes: integrations#958

Signed-off-by: Edward Wilde <[email protected]>

Co-authored-by: Edward Wilde <[email protected]>
kazaker pushed a commit to auto1-oss/terraform-provider-github that referenced this pull request Dec 28, 2022
Introduce support for managing github issues using the terraform provider.

Closes: integrations#958

Signed-off-by: Edward Wilde <[email protected]>

Co-authored-by: Edward Wilde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github_issue or github_project_issue
4 participants