-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WriteAPIBlocking discards http2.Error content #293
Comments
pabigot
added a commit
to pabigot/influxdb-client-go
that referenced
this issue
Dec 22, 2021
6 tasks
pabigot
added a commit
to pabigot/influxdb-client-go
that referenced
this issue
Dec 22, 2021
pabigot
added a commit
to pabigot/influxdb-client-go
that referenced
this issue
Dec 22, 2021
pabigot
added a commit
to pabigot/influxdb-client-go
that referenced
this issue
Dec 22, 2021
vlastahajek
added a commit
that referenced
this issue
Jan 4, 2022
fix: retain full error information for blocking writes (#293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The fixes for issue #235 included:
influxdb-client-go/api/writeAPIBlocking.go
Lines 76 to 78 in 4218b50
When the error is an http2.Error, e.g. because the token is unauthorized, this invokes:
influxdb-client-go/api/http/error.go
Lines 34 to 36 in 4218b50
errors.errorString
that has nothing but the text.So, unlike the non-blocking API, an error from WriteAPIBlocking() does not return an
http2.Error
, making it complex to understand why the write failed. The idiom proposed in #292 (comment) cannot recover the lost information.The text was updated successfully, but these errors were encountered: