refactor: eliminate single-use helper #8226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjsparks
approved these changes
Nov 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8226 +/- ##
==========================================
+ Coverage 88.78% 88.93% +0.14%
==========================================
Files 296 303 +7
Lines 41320 41282 -38
==========================================
+ Hits 36687 36715 +28
+ Misses 4633 4567 -66 ☔ View full report in Codecov by Sentry. |
jennifer-richards
added a commit
to jennifer-richards/datatracker
that referenced
this pull request
Nov 22, 2024
This reverts commit 6608c9d.
rjsparks
pushed a commit
that referenced
this pull request
Nov 22, 2024
* Revert "fix: ensure csrf cookie for searches (#8260)" This reverts commit 622ded5. * Revert "refactor: eliminate single-use helper (#8226)" This reverts commit 6608c9d. * Revert "feat: POST for document search requests (#8206)" This reverts commit b65a37b. * test: add back test fix * refactor: eliminate single-use helper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8206