feat: improve / clean up logging #7591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jennifer-richards
commented
Jun 25, 2024
jennifer-richards
commented
- Include more fields in JSON logs
- Extract gunicorn access log fields in JSON
- Put all gunicorn logs on stdout, leave django logs on stderr
- Replace syslog with Python logging (or remove the messages)
rjsparks
previously approved these changes
Jun 26, 2024
The gunicorn logger plays tricks with the LogRecord args parameter to let it have string keys instead of being a simple tuple. The mypy tests rightly flag this. Rather than fighting the typing, just remove the hints and leave a comment warning not to use the gunicorn-specific formatter with other loggers.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7591 +/- ##
==========================================
- Coverage 88.98% 88.79% -0.19%
==========================================
Files 291 295 +4
Lines 40717 41270 +553
==========================================
+ Hits 36233 36647 +414
- Misses 4484 4623 +139 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Jun 26, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.