fix: compatible with webpack-dev-server v3

ice-lab · Aug 27, 2021 · 516cefa · 516cefa
1 parent bcaf487
commit 516cefa
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 10 deletions.
diff --git a/packages/build-scripts/CHANGELOG.md b/packages/build-scripts/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.1.1
+
+- [fix] compatible with webpack-dev-server v3
+
 ## 1.1.0
 
 - [refactor] support custom command by extend Context

diff --git a/packages/build-scripts/bin/child-process-start.js b/packages/build-scripts/bin/child-process-start.js
@@ -48,8 +48,12 @@ const defaultPort = parseInt(DEFAULT_PORT || 3333, 10);
     });
 
     ['SIGINT', 'SIGTERM'].forEach(function(sig) {
-      process.on(sig, function() {
-        devServer.close();
+      process.on(sig, async function() {
+        if (devServer.close) {
+          devServer.close();
+        } else if (devServer.stop) {
+          await devServer.stop();
+        }
         process.exit(0);
       });
     });

diff --git a/packages/build-scripts/package.json b/packages/build-scripts/package.json
@@ -1,6 +1,6 @@
 {
   "name": "build-scripts",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "license": "MIT",
   "description": "scripts core",
   "main": "lib/index.js",

diff --git a/packages/build-scripts/src/service/start.ts b/packages/build-scripts/src/service/start.ts
@@ -86,27 +86,50 @@ export = async function(context: Context, options?: IRunOptions): Promise<void |
       stats,
     });
   });
+
+  let devServer: WebpackDevServer;
   // require webpack-dev-server after context setup
   // context may hijack webpack resolve
   // eslint-disable-next-line @typescript-eslint/no-var-requires
   const DevServer = require('webpack-dev-server');
-  const devServer: WebpackDevServer = new DevServer(devServerConfig, compiler);
+
+  // static method getFreePort in v4
+  if (DevServer.getFreePort) {
+    devServer = new DevServer(devServerConfig, compiler);
+  } else {
+    devServer = new DevServer(compiler, devServerConfig);
+  }
 
   await applyHook(`before.${command}.devServer`, {
     url: serverUrl,
     urls,
     devServer,
   });
-
-  devServer.startCallback(
-    () => {
-      applyHook(`after.${command}.devServer`, {
+  if (devServer.startCallback) {
+    devServer.startCallback(
+      () => {
+        applyHook(`after.${command}.devServer`, {
+          url: serverUrl,
+          urls,
+          devServer,
+        });
+      },
+    );
+  } else {
+    devServer.listen(devServerConfig.port, devServerConfig.host, async (err: Error) => {
+      if (err) {
+        log.info('WEBPACK',chalk.red('[ERR]: Failed to start webpack dev server'));
+        log.error('WEBPACK', (err.stack || err.toString()));
+      }
+      await applyHook(`after.${command}.devServer`, {
         url: serverUrl,
         urls,
         devServer,
+        err,
       });
-    },
-  );
+    });
+  }
+
 
   return devServer;
 };