This repository has been archived by the owner on Oct 16, 2021. It is now read-only.
Added for loop to Encode function to support big-endian machines #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used stack allocation instead of heap allocation to improve speed of endianness correction
joransiu
added a commit
that referenced
this pull request
Oct 28, 2015
Swap bytes for UCS2 in StringBytes::Encode on Big Endian platforms
|
Thanks @exinfinitum. We'll incorporate this fix temporarily to ensure address the issue is not exposed for our big-endian platforms. We'll replace with the community fix once that is finalized. |
|
There is an issue with this fix, as StringSlice also includes a byteswap for UCS2. This led to some Node FVT failures with StringBuffer due to double swapping. The proper change should be having the byteswap in String::Encode. We'll need a follow-on fix to update StringSlice. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix for nodejs/node#3409, pulling over code from v0.12. This fix has not yet been finalized in the community node.js version.