Use default namespace from useTranslation hook if supplied

[heivo]

No description provided.

[heivo]

This is a fix for issue #161

[karellm]

Thanks for the PR, I added a small comment.

I don't use this feature but I don't have any objection to add this. @vincaslt wdyt?

[heivo]

I just saw that there is also a option to override the namespace (see #192 ), trying to fix this in this PR, too.

[heivo]

I added a feature to evaluate namespace overrides in the t-function options (see docs here: https://www.i18next.com/translation-function/essentials).

[hschmied]

@heivo if you could just help me out for a minute, I looked at the commit and see that your code checks if a namespace is given in useTranslation 'string' as well as an array of namespaces, in which case the first one is considered default. (lines 80-82 in your javascript-lexer.js commit)

we are using 1.0.6 of the parser, but for whatever reason, when using a namespace array when initializing 't', the parser is not parsing correctly keys without given namespace (falling back on default).

const {t, i18n} = useTranslation('localization', {useSuspense: true});
...
<Text>{t('test_fig')}</Text>

... correctly puts it into localization.json ...

const {t, i18n} = useTranslation(['localization', 'app', 'common'], {useSuspense: true});
...
<Text>{t('test_fig')}</Text>

... does not. instead it writes it into translation.json

---

Btw -- the test included with the commit only checks for useTranslate with namespace-string, but not array.

Thanks & best regards!
-H

[heivo]

@hschmied I think the problem is more related to lines 90-92: when an array is supplied as the first argument the namespace cannot be read from node.arguments[0].text but from node.arguments[0].elements[0].text.

Something like this should work:

if (node.expression.escapedText === "useTranslation" && node.arguments.length) {
	const { text, elements } = node.arguments[0];
	if (text) {
		this.defaultNamespace = text;
	} else if (elements && elements.length) {
		this.defaultNamespace = elements[0].text;
	}
}

[hschmied]

@heivo jep... that did it and works beautifully! How do you want to proceed to get this change in? I mean you fixed it and should get the credit. :)

[karellm]

This should be fixed in 1.0.7.

EDIT: actually you can now move to 2.0.0 which drops support for node 6 and 8 which are EOL.