chore: Add cargo-hack to check features
#105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucio Franco <[email protected]>
LucioFranco
commented
Oct 31, 2019
| - name: Check features | ||
| run: cargo hack check --all --each-feature | ||
| - name: Check all targets | ||
| run: cargo check --all --all-targets --all-features |
There was a problem hiding this comment.
I need to add the all-targets or else it will miss benchmarks, do you think there might be a better solution @taiki-e?
There was a problem hiding this comment.
Hmm, I'm not sure if there is another good solution. (afaik, --all-targets is basically the same as --lib --bins --examples --tests --benches, and note that the document is not checked (rust-lang/cargo#6669)
There was a problem hiding this comment.
if we run it last it should be fine I can wait till we fine a better solution.
taiki-e
reviewed
Oct 31, 2019
Co-Authored-By: Taiki Endo <[email protected]>
|
@taiki-e thank you so much for this crate, its what I very much wanted but had no clue how to express what I wanted. <3 |
rabbitinspace
pushed a commit
to satelit-project/tonic
that referenced
this pull request
Jan 1, 2020
* chore: Add `cargo-hack` to check features Signed-off-by: Lucio Franco <[email protected]> * Update .github/workflows/CI.yml Co-Authored-By: Taiki Endo <[email protected]>
brentalanmiller
pushed a commit
to brentalanmiller/tonic
that referenced
this pull request
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @taiki-e this crate is awesome :)
Signed-off-by: Lucio Franco [email protected]