Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codeowners with individual model owners #35595

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Rocketknight1
Copy link
Member

@Rocketknight1 Rocketknight1 commented Jan 9, 2025

Right now, the CODEOWNERS file tags me to review everything, and this will cause me to die 🪦

This PR adds an autogenerated list of model owners. Right now it gets categories from _toctree.yml and default owners from ISSUE_TEMPLATE/bug_report.yml, but I can probably improve on this!

TODO:

  • Split up text models, they shouldn't all go to @ArthurZucker
  • Split up multimodal models, they got assigned to @zucchini-nlp but not all of them are VLMs

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COol!
With this, I think a lot of people are still gonna get pinged on the image_processor (ex from the PR where everyone was pinged) like in the Emu PR!

But it might help if the owner just reviews that piece of code (the image processor) and approves it -> I don't even look at it!

CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@qubvel qubvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for update!

CODEOWNERS Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
@Rocketknight1
Copy link
Member Author

Changed the globs to match /[model_name]/mod*_[model_name] so we capture modular and modeling changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants