Security fix for self-comment-ci.yml
#35548
Open
+289
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit ccc4a5a.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
commented
Jan 7, 2025
| id: get_sha | ||
| env: | ||
| PR_NUMBER: ${{ needs.get-pr-number.outputs.PR_NUMBER }} | ||
| COMMENT_DATE: ${{ github.event.comment.created_at }} |
There was a problem hiding this comment.
COMMENT_DATE: ${{ github.event.comment.created_at }}
new for security
ydshieh
commented
Jan 7, 2025
Comment on lines
+62
to
+72
| git fetch origin refs/pull/$PR_NUMBER/merge:refs/remotes/pull/$PR_NUMBER/merge | ||
| git checkout refs/remotes/pull/$PR_NUMBER/merge | ||
| PR_MERGE_COMMIT_TIMESTAMP=$(git log -1 --date=unix --format=%cd) | ||
| echo "PR_MERGE_COMMIT_TIMESTAMP: $PR_MERGE_COMMIT_TIMESTAMP" | ||
| COMMENT_TIMESTAMP=$(date -d "${COMMENT_DATE}" +"%s") | ||
| echo "PR_HEAD_SHA: $COMMENT_DATE" | ||
| echo "COMMENT_TIMESTAMP: $COMMENT_TIMESTAMP" | ||
| if [ $COMMENT_TIMESTAMP -le $PR_MERGE_COMMIT_TIMESTAMP ]; then | ||
| echo "Last commit on the pull request is newer than the issue comment triggering this run! Abort!"; | ||
| exit -1; | ||
| fi |
There was a problem hiding this comment.
new for security
from the line git fetch origin refs/pull/$PR_NUMBER/merge:refs/remotes/pull/$PR_NUMBER/merge to here
There was a problem hiding this comment.
Currently I am using the merge commit.
(merge commit = PR head commit merged with main )
Merge commit might change if there is a push or merge to the main branch. So it would be better to use the head commit of the PR instead.
|
a failing run looks like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.