Skip to content

Commit

Permalink
fix(lint): fix 'make install' failure due to bad 'BeginTransaction' c… (
Browse files Browse the repository at this point in the history
gnolang#3369)

Addresses gnolang#3368 

…all in lint.io

lint.go: add missing 'gasMeter' param to 'BeginTransaction' call

Impact: caused 'make install' to fail on branch 'master' with the
following error:

cmd/gno/lint.go:147:34: not enough arguments in call to
ts.BeginTransaction
        have ("github.com/gnolang/gno/tm2/pkg/store/types".Store,
              "github.com/gnolang/gno/tm2/pkg/store/types".Store)
        want ("github.com/gnolang/gno/tm2/pkg/store/types".Store,
              "github.com/gnolang/gno/tm2/pkg/store/types".Store,
              "github.com/gnolang/gno/tm2/pkg/store/types".GasMeter)
    make[1]: *** [install] Error 1

Testing: This fix resolves test failure commanded by `make test`:

    FAIL	github.com/gnolang/gno/gnovm/cmd/gno [build failed]
  • Loading branch information
dmanpearl authored Dec 19, 2024
1 parent d69b552 commit c8cd8f4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion gnovm/cmd/gno/lint.go
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ func execLint(cfg *lintCfg, args []string, io commands.IO) error {
// Wrap in cache wrap so execution of the linter doesn't impact
// other packages.
cw := bs.CacheWrap()
gs := ts.BeginTransaction(cw, cw)
gs := ts.BeginTransaction(cw, cw, nil)

// Run type checking
if gmFile == nil || !gmFile.Draft {
Expand Down

0 comments on commit c8cd8f4

Please sign in to comment.