-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SSDP page to add Onkyo #36866
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request adds the Onkyo integration to the list of devices that can be automatically discovered through the SSDP (Simple Service Discovery Protocol) integration. This modification expands the network device detection capabilities by including Onkyo devices, allowing for easier automatic identification and setup of these devices within the system. Changes
Note: No sequence diagram is generated for this change as it is a simple list modification without significant control flow or interaction changes. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/ssdp.markdown (1)
43-43
: Fix indentation to match other entries.The Onkyo entry is correctly placed in alphabetical order and follows the proper link format. However, the line has an extra space before the bullet point that should be removed to match the indentation of other entries.
- - [Onkyo](/integrations/onkyo/) -[Onkyo](/integrations/onkyo/)🧰 Tools
🪛 Markdownlint (0.37.0)
43-43: Expected: 0; Actual: 1
Unordered list indentation(MD007, ul-indent)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/ssdp.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/ssdp.markdown
43-43: Expected: 0; Actual: 1
Unordered list indentation
(MD007, ul-indent)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Proposed change
Adds Onkyo to the list of SSDP supported integrations, which was merged and released in 2025.1
home-assistant/core#131066
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit