-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update google_assistant.markdown with important warning #36857
base: current
Are you sure you want to change the base?
Conversation
The manual setup process does not work. People should be directed to the relevant discussion
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request introduces a new informational note in the Google Assistant integration documentation, specifically warning users about a current issue with the manual setup procedure. The note explains that the manual setup is broken due to recent changes in the Google Developer Console and provides a link to a related GitHub issue for more information. Changes
Note: No functional changes were made to the integration itself, only documentation was updated with a warning for users. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
source/_integrations/google_assistant.markdown (1)
30-32
: LGTM! The warning is clear and well-placed.The warning effectively communicates that the manual setup is broken and directs users to the relevant GitHub issue for updates.
Consider formatting the URL for better accessibility.
Format the URL as a proper Markdown link for better accessibility and consistency with documentation standards.
-Note: The Manual setup procedure is broken due to recent changes in Google Developer Console. Please follow up here: https://github.com/home-assistant/home-assistant.io/issues/35867 +Note: The Manual setup procedure is broken due to recent changes in Google Developer Console. Please follow up [here](https://github.com/home-assistant/home-assistant.io/issues/35867).🧰 Tools
🪛 Markdownlint (0.37.0)
31-31: null
Bare URL used(MD034, no-bare-urls)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/google_assistant.markdown
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/google_assistant.markdown
31-31: null
Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
The manual setup process does not work. People should be directed to the relevant discussion
Proposed change
Add a warning that the Google Assistant integration's manual setup is not working right now. It is important to post something now because the integration with manual setup is broken, and people should not waste time on it for nothing.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit