Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google_assistant.markdown with important warning #36857

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

maorcc
Copy link
Contributor

@maorcc maorcc commented Jan 10, 2025

The manual setup process does not work. People should be directed to the relevant discussion

Proposed change

Add a warning that the Google Assistant integration's manual setup is not working right now. It is important to post something now because the integration with manual setup is broken, and people should not waste time on it for nothing.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • Documentation
    • Added a warning note about the current manual setup procedure for the Google Assistant integration being broken
    • Provided a link to a GitHub issue for users experiencing setup difficulties

The manual setup process does not work. People should be directed to the relevant discussion
@home-assistant home-assistant bot added the current This PR goes into the current branch label Jan 10, 2025
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit b13c081
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/67813ddd23fcb30008506c7b
😎 Deploy Preview https://deploy-preview-36857--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Jan 10, 2025

📝 Walkthrough

Walkthrough

The pull request introduces a new informational note in the Google Assistant integration documentation, specifically warning users about a current issue with the manual setup procedure. The note explains that the manual setup is broken due to recent changes in the Google Developer Console and provides a link to a related GitHub issue for more information.

Changes

File Change Summary
source/_integrations/google_assistant.markdown Added an important warning note about manual setup being broken due to Google Developer Console changes

Note: No functional changes were made to the integration itself, only documentation was updated with a warning for users.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
source/_integrations/google_assistant.markdown (1)

30-32: LGTM! The warning is clear and well-placed.

The warning effectively communicates that the manual setup is broken and directs users to the relevant GitHub issue for updates.

Consider formatting the URL for better accessibility.

Format the URL as a proper Markdown link for better accessibility and consistency with documentation standards.

-Note: The Manual setup procedure is broken due to recent changes in Google Developer Console.  Please follow up here: https://github.com/home-assistant/home-assistant.io/issues/35867
+Note: The Manual setup procedure is broken due to recent changes in Google Developer Console. Please follow up [here](https://github.com/home-assistant/home-assistant.io/issues/35867).
🧰 Tools
🪛 Markdownlint (0.37.0)

31-31: null
Bare URL used

(MD034, no-bare-urls)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e75150c and b13c081.

📒 Files selected for processing (1)
  • source/_integrations/google_assistant.markdown (1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.37.0)
source/_integrations/google_assistant.markdown

31-31: null
Bare URL used

(MD034, no-bare-urls)

⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Redirect rules - home-assistant-docs
  • GitHub Check: Header rules - home-assistant-docs
  • GitHub Check: Pages changed - home-assistant-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current This PR goes into the current branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant