Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed json.schemas.url for devcontainers #135281

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Master-Guy
Copy link

Changed json.schemas.url for devcontainers to absolute path to resolve a warning in VSCode when working with devcontainers as documented.

https://discord.com/channels/330944238910963714/554842238073700352/1327207976423002245

Proposed change

When using VSCode and devcontainers, VSCode shows a warning regarding the manifest not existing:
image
This change gives the devcontainer an absolute path to work with, so this warning is no longer shown.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Please see the Discord chats about this issue here:
https://discord.com/channels/330944238910963714/554842238073700352/1327207976423002245

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@Master-Guy Master-Guy requested a review from a team as a code owner January 10, 2025 10:35
@home-assistant home-assistant bot added bugfix cla-needed small-pr PRs with less than 30 lines. labels Jan 10, 2025
Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Master-Guy

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant bot marked this pull request as draft January 10, 2025 10:35
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Master-Guy Master-Guy marked this pull request as ready for review January 10, 2025 10:37
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft January 10, 2025 10:40
@Master-Guy Master-Guy marked this pull request as ready for review January 10, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants