Discover new devices at runtime in onewire #135199
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
home-assistant
bot
added
integration: onewire
by-code-owner
Quality Scale: No score
labels
|
Hey there @garbled1, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
epenet
force-pushed
the
epenet-20250109-1521
branch
from
ad8db94 to
c3145a3
Compare
| SIGNAL_NEW_DEVICE_CONNECTED = SignalType["OneWireHub", list[OWDeviceDescription]]( | ||
| f"{DOMAIN}_new_device_connected" | ||
| ) |
There was a problem hiding this comment.
oh we even have these types now? Neat
There was a problem hiding this comment.
oh we even have these types now? Neat
Yeah - just stumbled upon it myself!
| async_fire_time_changed(hass) | ||
| await hass.async_block_till_done(wait_background_tasks=True) | ||
|
|
||
| await snapshot_platform(hass, entity_registry, snapshot, config_entry.entry_id) |
There was a problem hiding this comment.
Let's not add more snapshots unless there is any relevance in storing the data. Because I think this test would also be good if we just checked that we discovered them. This avoid unneeded snapshots
There was a problem hiding this comment.
Let's not add more snapshots unless there is any relevance in storing the data. Because I think this test would also be good if we just checked that we discovered them. This avoid unneeded snapshots
Removed
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
epenet
force-pushed
the
epenet-20250109-1521
branch
from
b49adc2 to
224bc79
Compare
|
Rebased to fix conflicts |
Proposed change
Scan the bus every 5 minutes, and use dispatcher to create the new entities
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: