Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum SQLite version to 3.40.1 #135042

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Change minimum SQLite version to 3.40.1 #135042

merged 3 commits into from
Jan 9, 2025

Conversation

gjohansson-ST
Copy link
Member

Breaking change

Version 3.32.0 was deprecated in #104298 and minimum SQLite version is now 3.40.1

Proposed change

See breaking

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 7, 2025

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gjohansson-ST gjohansson-ST requested review from bdraco and removed request for a team January 7, 2025 21:33
@bdraco
Copy link
Member

bdraco commented Jan 9, 2025

re-running as I'm assuming the failure is unrelated and transient, but since it was a db CI, I want to be sure

@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Jan 9, 2025
@bdraco bdraco merged commit 64752af into dev Jan 9, 2025
64 checks passed
@bdraco bdraco deleted the gj-20250107-04 branch January 9, 2025 02:34
@bdraco bdraco removed the smash Indicator this PR is close to finish for merging or closing label Jan 9, 2025
bdraco added a commit that referenced this pull request Jan 9, 2025
bdraco added a commit that referenced this pull request Jan 9, 2025
no longer needed after #135042

Note that max_bind_vars is not removed from the DatabaseEngine
dataclass since its still used in a few tests. It may be removed
in a future PR.
@bdraco bdraco mentioned this pull request Jan 9, 2025
19 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants