Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from host to ip in zeroconf discovery for slide_local #134709

Merged

Conversation

dontinelli
Copy link
Contributor

Proposed change

The host name in the discovery_info is not always usable to connect, so that the discovery can fail:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/slide_local/config_flow.py", line 61, in async_test_connection
    result = await slide.slide_info(user_input[CONF_HOST])
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/goslideapi/goslideapi.py", line 694, in slide_info
    result = await self._request(
             ^^^^^^^^^^^^^^^^^^^^
    ...<5 lines>...
    )
    ^
  File "/usr/local/lib/python3.13/site-packages/goslideapi/goslideapi.py", line 629, in _request
    respstatus, resptext = await self._dorequest(reqtype, url, data=data)
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/goslideapi/goslideapi.py", line 515, in _dorequest
    async with aiohttp.request(
               ~~~~~~~~~~~~~~~^
        reqtype, url, headers=headers, json=data, timeout=atimeout
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ) as resp:
    ^
  File "/usr/local/lib/python3.13/site-packages/aiohttp/client.py", line 1456, in __aenter__
    self._resp = await self._coro
                 ^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.13/site-packages/aiohttp/client.py", line 622, in _request
    raise err_exc_cls(url)
aiohttp.client_exceptions.InvalidUrlClientError: http:///rpc/Slide.GetInfo

I therefore suggest to change to the IP address of the device.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@dontinelli dontinelli marked this pull request as ready for review January 4, 2025 20:18
@joostlek joostlek added this to the 2025.1.1 milestone Jan 4, 2025
@joostlek joostlek merged commit 0d3872a into home-assistant:dev Jan 4, 2025
34 checks passed
@dontinelli dontinelli deleted the dontinelli-slide_local-if_fix branch January 4, 2025 20:29
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants