Letsencrypt: Add support for noris network DNS provider #3697
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
WalkthroughWalkthroughThe Let's Encrypt project has been enhanced with the addition of support for the Noris Network DNS challenge, allowing users to effectively manage DNS challenges associated with this provider. Updates span documentation, configuration files, and scripts to ensure comprehensive integration of the new DNS provider, improving the overall functionality and flexibility for users requiring DNS management solutions. Changes
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
letsencrypt/DOCS.md
Outdated
|
|
||
| To obtain the `noris_token` follow the instructions as described in our [GitHub repository][GitHub repo]. | ||
|
|
||
| You can define the `propagation_seconds` explicitly, otherwise it will use the default value (currently set to `60` seconds). |
There was a problem hiding this comment.
Fix typographical issue with "otherwise".
The word “otherwise” should be separated from the sentence with a period or semicolon.
- You can define the `propagation_seconds` explicitly, otherwise it will use the default value (currently set to `60` seconds).
+ You can define the `propagation_seconds` explicitly. Otherwise, it will use the default value (currently set to `60` seconds).Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| You can define the `propagation_seconds` explicitly, otherwise it will use the default value (currently set to `60` seconds). | |
| You can define the `propagation_seconds` explicitly. Otherwise, it will use the default value (currently set to `60` seconds). |
Tools
LanguageTool
[typographical] ~950-~950: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...ou can define thepropagation_secondsexplicitly, otherwise it will use the default value (currentl...(THUS_SENTENCE)
…nt#3697) * Add support for noris network DNS provider * Fix typographical issue
dns-norisauthenticator to Letsencrypt addon.Summary by CodeRabbit
New Features
dns-noris, with updated configuration instructions in the documentation.Documentation
dns-norisprovider and its configuration requirements.Configuration Changes