Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional dependencies from meta.yaml #6878

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Remove optional dependencies from meta.yaml #6878

merged 3 commits into from
Jun 11, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 30, 2024

We could see in previous versions of our conda package we didn't package with recommendations as we do in HoloViews.

image

This also removes the need for the standard optional dependencies group.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (55f71a9) to head (e8542a0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6878      +/-   ##
==========================================
- Coverage   81.52%   81.51%   -0.02%     
==========================================
  Files         319      319              
  Lines       46895    46895              
==========================================
- Hits        38233    38225       -8     
- Misses       8662     8670       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Outdated Show resolved Hide resolved
@hoxbro hoxbro requested a review from philippjfr June 11, 2024 12:20
@philippjfr philippjfr merged commit c6422aa into main Jun 11, 2024
9 checks passed
@philippjfr philippjfr deleted the no_optional branch June 11, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants