forked from ayende/rhino-security
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to netstandard 2.0 and add Linq support #12
Open
whyer
wants to merge
46
commits into
hibernating-rhinos:master
Choose a base branch
from
whyer:feature/upgrade-and-add-linq-support
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Upgrade to netstandard 2.0 and add Linq support #12
whyer
wants to merge
46
commits into
hibernating-rhinos:master
from
whyer:feature/upgrade-and-add-linq-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed when running against SQL Server, error message contain UNIQUE not unique (upper case).
The problems with second level cache found earlier by wut was not a problem with the queries. The problem was that without Equals/GetHashCode on User Nhibernate cannot compare objects when removing from collections. So nothing was removed from collections and the tests failed.
Instead we build the expression from the string with the property name
whyer
changed the title
Feature/upgrade and add linq support
Upgrade to netstandard 2.0 and add Linq support
Dec 20, 2019
Better to return the new query than to change the one sent in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrecting this library. I upgraded the solution to netstandard 2.0 and added a much needed Linq support to the authorizationService.AddPermissionsToQuery() metod.